Updated webrev at: http://cr.opensolaris.org/~bpytlik/ips-4048-v2/
Danek Duvall wrote: > On Fri, Oct 17, 2008 at 08:25:59PM -0700, Brock Pytlik wrote: > > >> http://cr.opensolaris.org/~bpytlik/ips-4048-v1/ >> > > server/catalog.py: > > - line 239: Why emsg() instead of cherrypy.log here? And perhaps we > should just put this in a try block instead of behind an if? The read > itself could fail, so we might as well handle that, too. > Good point, changed to us cherrypy and a try/catch block > t_pkg_search.py: > > - line 840, 859: TMP is a directory in the real code; perhaps it should > be here, too? > It doesn't make any difference right now but sure. > testutils.py: > > - line 435: no spaces around =. > Fixed Thanks for the review. Brock > Danek > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
