[EMAIL PROTECTED] wrote: >> Updated webrev at: >> http://cr.opensolaris.org/~bpytlik/ips-4048-v2/ >> > > Just one nit from me. > > server/catalog.py: > > - line 284: I found this idiom odd. You don't have to change this, > but would it make more sense as: > > if self._search_available: > return True > return self._check_search() > > I'm not sure, but I wondered. > > -j > I do like that better, definitely easier to understand. I'll change that and put back unless others have comments.
Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
