Hi all, I'm looking for a review of the fix for bug #4100:
http://defect.opensolaris.org/bz/show_bug.cgi?id=4100 Need to add package category/sub-category data for 2008.11 Webrev is at: http://cr.opensolaris.org/~richb/pkg-4100-v1/ This is a huge patch of mostly similar small changes. Probably easiest to look at the gate.patch file. There are two parts to the fix: 1/ Changes to .../gate/src/util/distro-import/solaris.py to recognize lines in the various .../distro-import/<NN>/[common,i386,sparc]/<package_name> files containing info.classification lines such as: info.classification "org.opensolaris.category.2008::System/Libraries (System)" Note that it was done as a separate new recognized token (rather than put them in via "add set ..." lines), so that the information could be included in the package summaries and to easily isolate this functionality should we want to to anything else with it. 2/ Changes to the latest package source files found under .../distro-import/<nn>/[common,i386,sparc]/<package_name> using the data generated from the GUI Package Manager categorization. 1127 of them. To do this, I wrote a simple Python script file that automatically updated the latest versions of all the relevant packages in my pkg hg workspace. See: http://defect.opensolaris.org/bz/attachment.cgi?id=609 Note that I'm not asking for a review of the code quality of this script (it's a throwaway). Just a check that it's doing the right thing. The changes were tested by doing a full redist_import of build 100a and putting all the packages into a local repository. Sun internal people can see the packages via their web browser at: http://stard.sfbay.sun.com:23141 Note that I had to comment out the line for usr/lib/lzma.so in the .../distro-import/100a/common/SUNWcs package definition in order to test this: $ hg diff SUNWcs diff -r 77b19d8766e7 src/util/distro-import/100a/common/SUNWcs --- a/src/util/distro-import/100a/common/SUNWcs Tue Oct 21 00:16:36 2008 -0700 +++ b/src/util/distro-import/100a/common/SUNWcs Tue Oct 21 09:05:20 2008 -0700 @@ -31,7 +32,7 @@ # XXX until new clofi hits nevada drop usr/sbin/lofiadm from SUNWclofi import -usr/lib/lzma.so +# usr/lib/lzma.so usr/sbin/lofiadm end import import SUNWcsr See: http://mail.opensolaris.org/pipermail/pkg-discuss/2008-October/007568.html for more details. This change is not included in the webrev. Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
