Brock Pytlik wrote: > Webrev: > http://cr.opensolaris.org/~bpytlik/ips-4114-v1/ > > Bug: > Api.Info needs to provide more info > http://defect.opensolaris.org/bz/show_bug.cgi?id=4114
api_versions.txt: line 6: s/Adds new the/Adds the/ client.py: lines 1038, 1041, 1044, 1047, 1050: long-term, are these going to be wrapped somehow with _()? lines 1040, 1043, 1046, 1049, 1052: You don't need the "%s" as msg() itself will do that implicitly, so you should just be able to pass whatever value it is. lines 1037ff: It would be nice if only printed each section if there were any links, dependencies, etc. pkg.1.txt: line 146: s/. This/. This/ line 148: s/. This/. This/ api.py: line 583: drop spaces around '=' lines 699-700: these don't seem necessary line 832: drop spaces around '=' lines 846-850: missing spaces around '=' Otherwise, looks fine. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
