In general, this looks okay.  However, I'm concerned about the way we're
iterating through the manifest at line 683 in apy.py.  We've added a
dictionary the keeps track of the type of action to the manifest object.
We should be able to get this information without iterating over every
action in the manifest.

-j


On Tue, Oct 21, 2008 at 07:14:08PM -0700, Brock Pytlik wrote:
> Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-4114-v1/
> 
> Bug:
> Api.Info needs to provide more info
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4114
> 
> Thanks,
> Brock
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to