On Wed, Oct 29, 2008 at 10:56:07AM +0000, jmr wrote: > Ok - I've taken your latest patch Fujiwara and applied it against the gate. > There were a number of rejects that I have resolved. This builds and on an > initial smoke test looks fine. > > Please review to make sure this is ok to integrate. > > http://cr.opensolaris.org/~jmr/pm_4126_v3_Oct29/
Huh. This still doesn't resolve my concerns about the inconsistency of the way the i18n is handled, and there's a bug in misc.py that I finally noticed. I didn't have a chance to review this new code before you pushed it, and most of my concerns which I've raised several times over the past couple of days with Fujiwara hadn't been addressed yet, though I think we were making progress towards resolution. FWIW, the bug is that the unit names in the table of units are all i18ned, but the comparison on line 394 is against a non-i18ned string, which will fail if the unit names are, in fact localized. This can't have been tested. In very large cases (> 2^70), bytes_to_str() will return None, causing a stack trace. It probably should be uom on line 401 that gets i18ned. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
