Ah, rats. I sent a reply before I saw this. :( -j
On Wed, Oct 29, 2008 at 04:44:19PM -0500, Tom Mueller wrote: > Please ignore. I sent this message before I saw that 4323 was filed. > > Tom > > Tom Mueller (pkg-discuss) wrote: >> While this eliminates the traceback, it doesn't provide any clue to the >> user as to what to do next, especially if this is a case where the problem >> is that the user has not provided a cert/key and one is required. That >> was the intent when the issue was filed. >> >> Do you have examples of what the new output looks like with this change? >> >> Thanks. >> Tom >> >> [EMAIL PROTECTED] wrote: >> >>> Folks, >>> I have an easy code review that fixes a stack trace in the transport >>> path. This occurs because we catch sslerror execptions and then throw a >>> RuntimeError. The code that caught the RuntimeError has gone away, so >>> this escapes to the top level, causing a stack trace. >>> >>> The solution is to remove the special-case code that throws the >>> RuntimeError. The generic error handler for URLErrors (the sslerrors >>> get wrapped in a URLError when we use urllib) is able to handle these >>> errors correctly. >>> >>> Webrev here: >>> >>> http://cr.opensolaris.org/~johansen/webrev-4291/ >>> >>> -j >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> >> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> > > begin:vcard > fn:Tom Mueller > n:Mueller;Tom > org:Sun Microsystems, Inc.;Update Center Software > adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA > email;internet:[EMAIL PROTECTED] > title:Senior Staff Engineer > tel;work:877-250-4011 > tel;fax:877-250-4011 > tel;home:402-916-9943 > x-mozilla-html:TRUE > version:2.1 > end:vcard > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
