Looks fine to me. -Brad
On Wed, Oct 29, 2008 at 02:24:00PM -0700, [EMAIL PROTECTED] wrote: > Folks, > I have an easy code review that fixes a stack trace in the transport > path. This occurs because we catch sslerror execptions and then throw a > RuntimeError. The code that caught the RuntimeError has gone away, so > this escapes to the top level, causing a stack trace. > > The solution is to remove the special-case code that throws the > RuntimeError. The generic error handler for URLErrors (the sslerrors > get wrapped in a URLError when we use urllib) is able to handle these > errors correctly. > > Webrev here: > > http://cr.opensolaris.org/~johansen/webrev-4291/ > > -j > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
