[EMAIL PROTECTED] wrote: > Folks, > This is a code reveiw that addresses some problems with the initial > mirror selection heuristic. It was weighting the primary server equally > with the mirrors. In situations where the mirror was much faster than > the master, we'd still end up choosing the master and going much slower. > > The webrev can be found at the location below. > > http://cr.opensolaris.org/~johansen/webrev-3803/ > > With this fix in place, we'll only go to the master server for data if > we can't find the file in any of the mirrrors' repositories. > > This is also a small code review.
client.py: line 646-647: extraneous whitespace? general comment -- my personal preference is to see mirror stats show up as a result of specifying "-v" for verbose instead of using environment variables as an interface. Maybe use global_settings to implement this through -v? If PKG_MIRROR_STATS constitutes a valid interface, can you update pkg.1.txt? image.py: line 439-440: Perhaps, "All mirrors in the chosen_set have already been used; try the primary authority instead and reset the chosen_set to reflect that." ? Isn't "primary authority" just the authority origin and the mirrors are just mirrors? imageconfig.py: line 181: what effect will this have on existing pkg clients? The first time we read their imageconfig, will it still pick the authority first and after that not? -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
