* Shawn Walker <[EMAIL PROTECTED]> [2008-10-30 21:24]: > [EMAIL PROTECTED] wrote: > > Folks, > > This is a code reveiw that addresses some problems with the initial > > mirror selection heuristic. It was weighting the primary server equally > > with the mirrors. In situations where the mirror was much faster than > > the master, we'd still end up choosing the master and going much slower. > > > > The webrev can be found at the location below. > > > > http://cr.opensolaris.org/~johansen/webrev-3803/ > > > > With this fix in place, we'll only go to the master server for data if > > we can't find the file in any of the mirrrors' repositories. > > > > This is also a small code review. > > client.py: > line 646-647: extraneous whitespace? > > general comment -- my personal preference is to see mirror stats show > up as a result of specifying "-v" for verbose instead of using > environment variables as an interface. Maybe use global_settings to > implement this through -v? If PKG_MIRROR_STATS constitutes a valid > interface, can you update pkg.1.txt? I asked for this to be an informal way to see these stats. Dan wants to change the -v output; I asked K to not dump these into that output given that plan. We can revisit when that plan for -v comes into being.
> image.py: > line 439-440: Perhaps, "All mirrors in the chosen_set have already > been used; try the primary authority instead and reset the chosen_set to > reflect that." ? > > Isn't "primary authority" just the authority origin and the mirrors are > just mirrors? I'd like to see origin server or origin URL here, too. - Stephen -- [EMAIL PROTECTED] http://blogs.sun.com/sch/ _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
