[EMAIL PROTECTED] wrote: > Folks, > > Brock found this bug while we were discussing the fate of another bug > regarding error handling. This fixes a case where filelist is throwing > a RuntimeError where it really shouldn't. > > Webrev for the fix is here: > > http://cr.opensolaris.org/~johansen/webrev-4381/ > > Thanks, > > -j > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > I'm fine with this for now. I think in general, it's better to pass the data to the exception directly, and have the str method build the string. I couldn't find where FileListRetrievalError was defined though, so I'm not certain if that's possible in this situation. Can you test what happens to the Packagemanager when/if this new exception reaches client code? Actually, from what I can tell, it won't be any worse than what happened with the RuntimeException, but we should still check, and file a bug against the gui if the exception would take it down.
Thanks, Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
