> > http://cr.opensolaris.org/~johansen/webrev-4381/ > > Instead of raising a FileListRetrievalError, I'd rather throw an > exception specific to the problem. Maybe a StorageException instead or > a StoragePermissionsException? > > Of course, that depends on whether our exceptions are intended to be > specific to the operation or to the error...
Right now, the exceptions are specific to the operation. We've been sticking relevant error messages into the exception, so the top level handler will print a useful message about the error to the user. I'm not really sure how to respond to the rest of your comments, since they seem like architectural concerns that don't directly relate to this bugfix. I'm just imitating what we already have. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
