On Fri, Oct 31, 2008 at 11:37:21AM -0700, [EMAIL PROTECTED] wrote: > Folks, > As I was browsing through the code this morning, I found some places > where we had redundant logic for our error handlers. Since this > generally makes the code cluttered and harder to read, I thought it > would make sense to remove it. > > Another small review here: > > http://cr.opensolaris.org/~johansen/webrev-4400/
Seems fine. It's a little weird to me that ECONNREFUSED gets to be called a TransferTimedOut exception, since it really isn't a timeout. I'd expect maybe that the various transport exception instances would have a "retryable" attribute which you could test when catching them, or maybe a multiple-inheritance scheme, where you had exceptions like RetryableTransferContentException which inherited from RetryableTransportException and TransferContentException, and you could catch RetryableTransportException to test for retryability. If you think this is highly desirable for November, go ahead as-is. I myself might experiment a bit and try to rationalize it a bit further, even though doing so would push it out. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
