> > Another small review here: > > > > http://cr.opensolaris.org/~johansen/webrev-4400/ > > > Looks fine to me. Personally, I can't tell from looking at the code > whether it should be a transfer content, or transfer timeout exception, > so I'll trust your decision there. Everything else looks good to me.
Thanks. It's a bit of a subtle distinction. Initially, TransferContentException was only raised when we received errors reading from the tar stream. With the fix for 3441 and 3878, I expanded it to include the ValueError/IncompleteRead errors that we were getting from httplib. Bascially, I intended the exception to be raised when we had problems getting content across an established connection. The TransferTimedOut exception was for transfers that timeout, but it quickly got expanded to handle HTTP error codes for timeouts. It seemed straight-forward to include retryable socket errors in that set of errors. Although, as I told Danek, I'm not opposed to creating a separate exception for retryable socket errors, if that's useful/desireable/less annoying. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
