On Tue 28 Oct 2008 at 07:37AM, Jerry Jelinek wrote:
> Can I get a code review for a prototype of the
> attach/detach support for the ipkg brand. There
> is a webrev at:
>
> http://cr.opensolaris.org/~gjelinek/webrev.4287/
>
> This also includes a small fix for
>
> 4236 ipkg zone fails to boot when alternate BE mounted.
>
> This is more of a first cut than the final version
> of things, so there are still some XXX-tbds in the
> scripts.
Jerry-- sorry for the delay in reviewing this. I looked at this today,
and pulled the patch down and played with it. It seems to work for me.
I don't have any deep comments about the code itself. I would like to
get this applied as soon as I can, if you think it is ready to go. The
RE dock is closing on Monday at 10am. Since I think this is clearly
better than what we had before and seems low risk, I will go ahead an
commit this late on Sunday if I don't hear from you otherwise.
One thing I was wondering is about what would happen in this scenario:
detach zone foo
image-update global zone
reboot
attach zone foo (-u)
Will that successfully attach the dataset? I was thinking
that it might get confused because the parent BE will be
different than what the zone is expecting. Or am I confused?
I've run out of time for this evening to test this, but will
try to poke at it some more over the weekend. Thanks again...
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
