New webrev at: http://cr.opensolaris.org/~bpytlik/ips-3234-v2/
[EMAIL PROTECTED] wrote: > Thanks for fixing these. Remind me to buy you a beer for 3234. > > Just grammatical nits from me: > > pkg.1.txt: > > - line 271 & 272: Would you be alright with re-writing the portion > after the comma as: > > choose a new unique identifier that identifies this image to its > authority > Sure. > - line 286 & 287: This is currently written as: > > "If a specific authorities are requested, ..." > > I would re-write this as one of the following: > > If a specific authority is requested, ... > > or > > If specific authorities are requested, ... > > Since you probably want the authorities at the end of the sentence to > agree with the one at the beginning, I suppose the plural case works > better. Of course, you could always change the end of the sentence, > too. > Thanks for catching this. I took option 2 as multiple authorities can be passed as arguments to pkg authority. > The rest looks good. > Thanks for taking a look. Brock > Thanks, > > -j > > > On Fri, Oct 31, 2008 at 04:13:09PM -0700, Brock Pytlik wrote: > >> Webrev: >> http://cr.opensolaris.org/~bpytlik/ips-3234-v1/ >> >> Bugs: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4384 >> Usage and man page options don't match >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3234 >> pkg(1) man page doesn't mention mirror options for set-authority >> >> Thanks, >> Brock >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
