Shawn Walker wrote: All comments accepted save those noted here:
> client/api_errors.py: > line 128: I don't think I would include "pkg: " in this string here > since this may be shown by the GUI, etc. Perhaps s/pkg: the/The/ ? I > realise that all the other messages in PlanCreationException do this, > but I don't think they should either. The other exceptions don't. > sigh. I'll wait w/ this change until we clean up error handling in general. > > line 235: commented code? see comment above code; when we remove rename we can add this assertion back in . > > cli/t_pkg_api_install.py: > line 152: assigning to res, e seems pointless here; maybe a comment > instead saying that the return value is intentionally ignored for > testing purposes? Removed; part of change I'd partially removed. > > > cli/t_pkg_install.py: > lines 774, 798: s/incoprs/incorps/ > > lines 813-814: do we have a bug for this? > 4425 pkg install should deal w/ complex dependency changes in one install Thanks for looking at this. Danek, webrev is updated. - Bart -- Bart Smaalders Solaris Kernel Performance [EMAIL PROTECTED] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
