Bart,
Even though the code for this change has already checked been checked
into the gate, I had a couple of questions/comments.
constraint.py:
line 239: has the following:
raise Constraint.Exception(
ConstraintException.PRESENCE_CONFLICT,
self, fmri_present)
It seems that the "Constraint.Exception" right after "raise" should be
"ConstraintException".
Also, at line 260, an exception with the PRESENCE_CONFLICT type is
created with the 3rd argument being a Constraint object rather than an
PkgFmri as is used here. While it appears that this will work, at least
as far as printing an error message (because they both implement
__str__, it isn't clear that this is what is desired.
image.py:
line 1652: In the get_installed_unbound_inc_list method, the inc_tuples
list is populated with tuples containing pairs of package names (the
depender and the dependee). But the second element of the tuple is never
used. So why use a tuple here at all? Why not just store the fmri_name
values in the list? This would eliminate the need to extract the first
elements of the tuples at the end of the method. If an inc list contains
the list of fmri_name values, then it would seem that the end of the
method could just be:
rv = set()
for a in inc:
if not a in dependents:
rv.add(a)
return list(rv)
Thanks.
Tom
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
