Dan Price wrote:
> On Tue 04 Nov 2008 at 01:59PM, Shawn Walker wrote:
>> Jerry Jelinek wrote:
>>> I have a fix for:
>>>
>>> 4513 need option to attach existing dataset
>>>
>>> There is a webrev at:
>>>
>>> http://cr.opensolaris.org/~gjelinek/webrev.4513/
>> src/brand/attach:
>> line 29: s/existing dataset\n/existing dataset.\n/
>>
>> I don't feel confident enough to comment on the rest.
>
> This looks good to me modulo one question.
>
> Must the mountpoint be set to legacy prior to mounting the dataset to do
> the verification step? It seems to me that if the mountpoint was
> already 'legacy' and the dataset was already mounted (by hand on /mnt,
> say), then this would fail... should we check to see if it is mounted
> using 'zfs list -o mounted'? That way we could just error out if the
> thing is already mounted.
Dan,
Thanks for looking at this.
I'll add some additional handling around that. What
I do when we detach a zone is leave it mounted and
set the mount point so that it is easy to archive up
the image for transfer to another machine. So this
works with your scenario of:
detach
image-update global
reboot
attach -d dataset
But there might be other scenarios, so I'll beef that
up a bit.
Thanks again,
Jerry
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
