I need a code review for: 6793 p2v support for ipkg-branded zones
There is a webrev at: http://cr.opensolaris.org/~gjelinek/webrev.6793/ The two large files, image_install and p2v, do not need to be fully reviewed since most of the code is the same as what we already have with the native brand in nevada. Here are the main differences to look at in these two files: image_install 113-153 The sanity check function is slightly different. p2v In the fix_smf function the logic at 223-237 is different than the native brand for determining hollow pkgs. The rm_pkgs function at 367-381 is slightly different since it uses pkg instead of pkgrm. The rest of the files are specific to IPS and should be reviewed. I made one interface change in the installer. I changed the old '-a' option, which was used to specify a different authority, to '-A', so that I could keep the '-a' option meaning consistent between the native and ipkg brands. Thanks, Jerry _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
