Looks fine to me. However, I don't think this will stop us from running into bugs like 4277. In that particular case, we're just going to have to remember that we created the file with a more restrictive mode, and must change it back when the file is renamed to the working copy. None of this is your fault, I'm just commenting for the sake of posterity.
-j On Tue, Nov 04, 2008 at 03:25:19PM -0800, Bart Smaalders wrote: > http://cr.opensolaris.org/~barts/166/ > > This one works around the problem by setting umask explicitly; > a fix to avoid this would change lots more code, inappropriate > at this point in the release as the same umask issue affects > all callers of file(..., "w") as well. > > -= Bart > > -- > Bart Smaalders Solaris Kernel Performance > [EMAIL PROTECTED] http://blogs.sun.com/barts > "You will contribute more with mercurial than with thunderbird." > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
