On Wed, Nov 05, 2008 at 05:29:50PM -0600, Shawn Walker wrote:

>>> http://cr.opensolaris.org/~swalker/pkg-4489-2/

depot.py:

  - line 155: use "" instead of ''.

testutils.py:

  - line 407: wouldn't you want this in the command.startswith("close")
    clause?  You could combine that test with the retcode test.

  - pkgsend_bulk() should have its docstring updated.  I like this solution
    better than the previous one, though.

t_pkg_depotd.py:

  - What happens when this testcase fails?  We don't get any access to the
    stack trace, do we?  Just that the command failed?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to