Shawn Walker wrote: > Danek Duvall wrote: >> On Thu, Nov 06, 2008 at 10:12:49AM -0600, Shawn Walker wrote: >> >>> http://cr.opensolaris.org/~swalker/pkg-4489-3/ >> testutils.py: >> >> - line 405: could move into the loop. Indeed, what is now 408 could be >> "for l in output.splitlines():" >> >>> Only if I change startswith("close ") to startswith("close"). There are a >>> few tests that don't have a space after close. I don't know why the space >>> is assumed to be there. >> A lot of people seem to want to start and end triple-quoted strings with a >> space, for some reason. I've no idea where that came from. You could do a >> strip() after the split, and simply test for equality with "close", I >> suppose. > > Well, a few tests purposefully use "close -A", etc. Although I suppose > in that case, I don't care, because it means that nothing will be published. > > Both of your changes have been made.
Correction, only the first, as the second hasn't been done due to the reasons I outlined and because the os.environ line if the close command is being executed. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
