Brock Pytlik wrote:
> Resynced again:
> http://cr.opensolaris.org/~bpytlik/ips-4260-v3/
> 
> I'd like this to make 2008.11, so if anyone has a spare cycle or two to 
> look at this, I'd really appreciate it.

doc/api_versions.txt:
   It would be nice if you could rename this client_api_versions.txt 
since there will eventually be a server api as well.

client/api.py:
   line 698:  This seems unnecessary given that ca.parse_category_info() 
already checks for this.

   line 843-845: this can be simplified to:
         self.category_info_list = category_info_list or []

cli/t_api_info.py:
   For the paranoid person in me, can you add a test info.classification 
that is more than just one or two categories deep just to ensure we 
handle the n-deep cases?

Otherwise, looks fine.

Cheers,
-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to