Danek Duvall wrote:
> On Wed, Nov 05, 2008 at 04:32:00PM -0800, Brock Pytlik wrote:
>
>   
>> http://cr.opensolaris.org/~bpytlik/ips-4260-v3/
>>     
>
> attributes.py:
>
>   - line 70: Are you expecting that parse_category_info() will one day
>     return more than one value?
>   
Yep, because one day I think we're going to support multiple schemes, so 
then this function will spit back a list of category/scheme pairs.
> api.py:
>
>   - line 696, 697: join.  Same 699, 700.
>   
Ok
>   - line 843: Probably should test explicitly against None -- if someone
>     passes in an empty list and expects it to get filled in, it won't work.
>
>   
Ok fixed.
> Danek
>   

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to