Shawn Walker wrote:
> Brock Pytlik wrote:
>> Webrev:
>> http://cr.opensolaris.org/~bpytlik/ips-4569-v1/
>>
>> Bugs:
>> 4569 pkg uninstall tracesback when lacking permissions
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4569
>>
>> 4649 pkg install and image-update without perms can still traceback
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4649
>>
>> 4657 user action removal can result in UnboundLocalError
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4657
>>
>> Another wad towards the prevention of permission related tracebacks.
>
> image.py:
> line 1081: s/OSError/EnvironmentError/ ?
Thanks
>
> t_pkg_install.py:
> line 1470: a newline before this would be nice
sure, first time I think I've been asked to ADD lines ;)
>
> line 1473: why do you need install_name and pname?
artifact of old code, install_name removed
>
> line 1474: leftover debugging code?
yep
>
> testutils.py:
> line 315: missing spaces around '=' for consistency
Fixed
>
>
> Otherwise, looks fine.
>
> Cheers,
Thanks for the review,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
