Danek Duvall wrote: > On Fri, Nov 07, 2008 at 06:05:28PM -0800, Brock Pytlik wrote: > > >> http://cr.opensolaris.org/~bpytlik/ips-4569-v1/ >> > > image.py: > > - line 1084: if you got a different errno, you want to re-raise. > > Yep > t_pkg_install.py: > > - line 1449: You always seem to set refresh=False when calling this > Hmm, yeah, I'll rework this code a bit to be more sane. > - line 1471: use splitlines() > Fixed > - line 1473, 1486: why both install_name and pname? > Bah, artifact of old code before I had manually_check_deps as a separate function. Fixed. > - line 1474: delete > Gone > - line 1497: does this need to be tested for insufficient perms, too? > Good idea. Turns out this had already been fixed, but adding the test is clearly a good idea. > Danek >
Thanks for the review. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
