Hi David, [email protected] wrote: >> I'd appreciate if I could get a review of this fix for #5746 >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5746 >> mysql dependencies broken in 2008.11 >> >> webrev is at: >> >> http://cr.opensolaris.org/~albertw/5746/ > > This looks OK although I wonder about adding the dependency on > SUNWmysql5 in SUNWmysql-python. As a binding, isn't SUNWmysql-python > akin to a plugin
Thanks for the review! The reason I left it requiring SUNWmysql5 is that SUNWmysql-python delivers /usr/lib/python2.4/vendor-packages/_mysql.so. According to ldd this needs libmysqlclient_r.so.15 which is delivered in SUNWmysql5. > yes, it only works with SUNWmysql5 installed but it > doesn't seem likely an attempt would be made to install it by itself. If it only works with mysql installed then I think mysql-python should depend it. From a user perspective if they install then mysql-python they expect my python scripts contacting mysql databases to be able to work. If we don't depend on it we are effectively pushing the onus back onto the user to work out the dependency which seems wrong. > Put another way, this seems similar to a Firefox plugin - would you > expect Firefox to be installed if someone just tried to install the > plugin? Yes actually :-) Though libflashplayer.so doesn't appear to be linked against anything in SUNWfirefox so perhaps firefox plugins don't technically require firefox. Cheers, ~Albert -- Albert White - Sun Ireland [email protected] _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
