I have spun another webrev http://cr.opensolaris.org/~padraig/ips-4463-v3/.
I have attempted to fix the issues you raised below and those I caused
in the pylint output.
I am not sure what to do about the errors
Undefined variable '_'
These errors also occur if I run pylint on the cli code.
Padraig
On 12/23/08 13:02, Michal Pryc wrote:
Padraig,
I think we could remove unnecessary "\" in the strings which have been
changed in this webrev:
http://cr.opensolaris.org/~padraig/ips-4463-v2/src/updatemanager.py.wdiff.html
Line: 369
http://cr.opensolaris.org/~padraig/ips-4463-v2/src/packagemanager.py.wdiff.html
Line: 362, 383, 398, 772,
http://cr.opensolaris.org/~padraig/ips-4463-v2/src/gui/modules/repository.py.wdiff.html
Line: 147
http://cr.opensolaris.org/~padraig/ips-4463-v2/src/gui/modules/installupdate.py.wdiff.html
Line: 199, 616, 656
http://cr.opensolaris.org/~padraig/ips-4463-v2/src/gui/modules/beadmin.py.wdiff.html
Line: 150
I also did pylint before and after change and the results are much
different, here are the per file pylint outputs:
http://cr.opensolaris.org/~migi/pylint_4463/
best
Michal
Padraig O'Briain wrote:
I have reworked the webrev
http://cr.opensolaris.org/~padraig/ips-4463-v2/
to also fix bug 5155 Some strings are not translated.
The newly translated strings are at lines 781 and 910 of updatemanager.py.
Padraig
On 12/22/08 10:12, Padraig O'Briain wrote:
The webrev http://cr.opensolaris.org/~padraig/ips-4463-v1/ fixes
bug 4463 Change PM and UM to use _() as opposed to self._()
In addition to changing self._ or sel.parent._ to _ I have also
translated two strings; at line 359 of beadmin.py and 285 of
installupdate.py. I also made some minor formatting changes and removed
redundant backslashes.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
