Padraig, So I think you can commit this to the gate then. best Michal
Shawn Walker wrote: > Padraig O'Briain wrote: >> I have spun another webrev >> http://cr.opensolaris.org/~padraig/ips-4463-v3/. >> >> I have attempted to fix the issues you raised below and those I caused >> in the pylint output. >> >> I am not sure what to do about the errors >> >> Undefined variable '_' >> >> >> These errors also occur if I run pylint on the cli code. > > You can't do anything about that; pylint isn't the smartest of tools. > > Instead, it should be handled through the .pylintrc: > > # Good variable names which should always be accepted, separated by a comma > good-names=i,j,k,ex,Run,_ > > # In this case we define '_' (the function name for gettext) so that pylint > # doesn't complain about things like _("this is i18n string") > additional-builtins=_ > > Cheers, _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
