On Mon, Dec 22, 2008 at 08:16:52PM -0600, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-5603-2/
catalog.py:
- line 137: rather than setting this "done" flag, you could, in
__set_perms(), redefine __set_perms() to an empty function:
self.__set_perms = lambda: None
Of course, if you ever think you need to call __set_perms() again for
real, then this wouldn't work.
- line 184, 185: shouldn't you use S_IMODE() here, too?
- line 189: why len()?
- line 248: this won't do anything if the catalog was initialized when
both files were there, which is most of the time, right? Same with the
other place you call __set_perms() other than the constructor?
t_catalog.py:
- line 104: "Catalog".
- line 129: couldn't you use assertRaises()?
Danek
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
