Danek Duvall wrote: > On Mon, Dec 22, 2008 at 08:16:52PM -0600, Shawn Walker wrote: > >> http://cr.opensolaris.org/~swalker/pkg-5603-2/ > > catalog.py: > > - line 137: rather than setting this "done" flag, you could, in > __set_perms(), redefine __set_perms() to an empty function: > > self.__set_perms = lambda: None > > Of course, if you ever think you need to call __set_perms() again for > real, then this wouldn't work.
It is possible at the moment for __set_perms to be called multiple times during a single execution. This happens, for example, when you start a repository for the first time with an empty directory. The catalog attrs file gets created at startup, but the actual catalog file doesn't until the first fmri gets published. > - line 184, 185: shouldn't you use S_IMODE() here, too? No, these lines are to report the modes I already obtained from S_IMODE() earlier or am expecting, unless I'm missing something. > - line 248: this won't do anything if the catalog was initialized when > both files were there, which is most of the time, right? Same with the > other place you call __set_perms() other than the constructor? See above. Everything else you mentioned I've changed. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
