Shawn, Thanks for your comments. See in-line.
On 01/08/09 17:10, Shawn Walker wrote: > Padraig O'Briain wrote: >> The webrev http://cr.opensolaris.org/~padraig/ips-5375-v2/ fixes >> Bug 5375 PackageManager repository management should include security >> info >> RFE 5595 packagemanager does not provide a way to manage / specify >> authority mirror >> >> When a repository is being added and its name starts with "https" a >> dialog is displayed allowing the user to specify SSL key and >> certificate. >> >> In "Modify Repository" dialog, mirrors can be added or removed and >> SSL key and certificate can be changed. > I will discuss your suggestions with xdesign and see whether they will accept them. > data/packagemanager.glade: > lines 2149-2120: suggested rewording, fixes: > > If this repository requires a SSL Key and Certificate, or it has > mirrors, add a new repository first and then modify to add this > information. > > lines 2919-2922: suggested rewording, fixes: > > If this repository requires a SSL Key and Certificate, please enter it > into the SSL section. > > If you want to alter the list of mirrors for this repository, use the > mirrors section. > > line 3346: an opacity of .999.... something? Really? Why not just 1.0? > I am not sure how this got to be there. There are similar lines at line 2092 and 2392. I will remove all three. > lines 3363-3365: > > This repository requires a SSL Key and SSL certificate. Enter the > location of these files in the spaces provided, or use the Browse > buttons to provide their location. > > gui/modules/repository.py: > All of your _() i18n strings are using the '%s' style of > substitution instead of the '%(var_name)s' style that is needed when > you have more than one substitution. > I do not understand what change you are requesting. Can you point me at some code which uses the style you want? Padraig > Cheers, _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
