Padraig O'Briain wrote:
> Shawn,
>
> Thanks for your comments. See in-line.
>
> On 01/08/09 17:10, Shawn Walker wrote:
>> Padraig O'Briain wrote:
>>> The webrev http://cr.opensolaris.org/~padraig/ips-5375-v2/ fixes
>>> Bug 5375 PackageManager repository management should include security
>>> info
>>> RFE 5595 packagemanager does not provide a way to manage / specify
>>> authority mirror
>>>
>>> When a repository is being added and its name starts with "https" a
>>> dialog is displayed allowing the user to specify SSL key and
>>> certificate.
>>>
>>> In "Modify Repository" dialog, mirrors can be added or removed and
>>> SSL key and certificate can be changed.
>>
> I will discuss your suggestions with xdesign and see whether they will
> accept them.
At the least, they need to fix a few of the minor grammatical errors.
>> lines 3363-3365:
>>
>> This repository requires a SSL Key and SSL certificate. Enter the
>> location of these files in the spaces provided, or use the Browse
>> buttons to provide their location.
>>
>> gui/modules/repository.py:
>> All of your _() i18n strings are using the '%s' style of
>> substitution instead of the '%(var_name)s' style that is needed when
>> you have more than one substitution.
>>
> I do not understand what change you are requesting. Can you point me at
> some code which uses the style you want?
An example from client.py:
except api_errors.VersionException, __e:
if __img:
__img.history.abort(RESULT_FAILED_UNKNOWN)
error(_("The pkg command appears out of sync with the "
"libraries provided \nby SUNWipkg. The client
version is "
"%(client)s while the library API version is
%(api)s") %
{'client': __e.received_version,
'api': __e.expected_version
})
__ret = 1
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
