Hi again. I'm officially withdrawing my second nit (quoted below). I felt guilty about not noticing/reporting it in my first set of comments and yadda, yadda, yadda it's now filed upstream against Gtk+ with a proof-of-concept patch that works with Padraig's current webrev. :-) http://bugzilla.gnome.org/show_bug.cgi?id=569042
Li, I hope you don't mind being added to the CC list. As I commented on the bug, gail and C are on my to-learn list. But fixing this issue on the Gtk side of things seems like something worth prioritizing for all users of the GNOME desktop. And I've no doubt this one will be an easy one for you. :-) Thanks guys! --Joanie On Fri, 2009-01-23 at 18:58 -0500, Joanmarie Diggs wrote: > Hi Padraig. > > On Fri, 2009-01-23 at 11:49 +0000, Padraig O'Briain wrote: > > > I have reworked the webrev so that the focus does not change when > > enabling or disabling a repository. > > I just tried it. That's so, so much better. Thanks!! > > I'm afraid I've since noticed one more a11y nit. Sorry! The check box > associated with the preferred repository/authority is not set to > sensitive; however, if you examine the associated table cell with > Accerciser it does expose STATE_SENSITIVE. Would it be possible to not > expose STATE_SENSITIVE in this particular case, leaving everything else > as you have it in your current webrev? If so, users who are blind could > still move focus to that check box for the purpose of examining its > state. When they did so, Orca would announce that the check box was > greyed out. Otherwise the user has no idea why his/her attempts to > toggle that check box are failing miserably. :-) > > I don't know off the top of my head how to make this change, so I can't > provide a code snippet. But I promise to look at the solution and get up > to speed on this sort of thing for providing future feedback. :-) > > Thanks again for your work on this! Take care. > --Joanie _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
