Once again, I'd like to repeat my warning about not using the client
API.  The authority enable/disable code is reaching into the image
object directly.  Despite lengthy discussions explaining why this is a
bad idea, these warnings have fallen on deaf ears.  It's entirely likely
that the authority implementation, and it's location in the image
object, will change in a future putback.  This means that your authority
support will end up being broken.  If you have an API method that is
shared between the CLI and GUI, we can make sure these problems don't
occur.

If a method doesn't exist for an operation that you're trying to
perform, file a bug against api-python or consider adding the support
to the API.

-j

On Thu, Feb 05, 2009 at 12:38:25PM +0000, Michal Pryc wrote:
> Padraig,
> LGTM, with one minor cosmetic thing:
> 
> http://cr.opensolaris.org/~padraig/ips-6014-v2/src/gui/modules/repository.py.wdiff.html
> 
> Line: 354 (is this empty line needed?)
> 
> Michal
> 
> Padraig O'Briain wrote:
> > The webrev http://cr.opensolaris.org/~padraig/ips-6014-v1/ fixes
> > 6014 Would like ability to disable authorities rather than deleting them
> > 5202 Catalog is refreshed too often for Manage Repositories dialog
> > operations
> >
> > A check box is added to the repository list to allow enabling and
> > disabling of a repository.
> > All the rows have been made sortable but the data is initially presented
> > unsorted.
> > For 5202 we avoid refreshing the catalog if the only changes the user
> > made was to change the preferred authority and change it back to the
> > original preferred authority before closing.
> >
> > Padraig
> > _______________________________________________
> > pkg-discuss mailing list
> > [email protected]
> > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
> 
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to