svc-pkg-depot: Given the changes on lines 76 and 95, I think that similar changes should be made for 86 and 105 (and elsewhere?)
retrive.py: I think a short comment explaining what na_ in variable names would be helpful. Maybe I'm just dense today, but it took me a long time to get that it (I think) means "no authority". I'm somewhat confused as to why you only look at the end FMRI for target in __get_intent_str, either I've got the role of fmri and target backwards, or there's a constraint being taken advantage of that's imposed by how the function is being used, I think. I think it's unfortunate that we'll lose some of our internal cross-repo information. Perhaps that's something that could be added to either image or repo configuration so that, for example, when a contrib or extras package had a dependency that p.o.o satisfied, we could know that, but if a package from life-for-solaris was involved, then it would just be "unknown". Other than that, LGTM Brock Shawn Walker wrote: > Greetings, > > The following webrev contains fixes or changes for the following issues: > > 6245 intent information is not properly sent > 6273 ability to always log request headers desired > > webrev: > http://cr.opensolaris.org/~swalker/pkg-6245-6273/ > > Change Summary: > * Added --debug command-line option to pkg.depotd > > * Added pkg/debug SMF property > > * Added --debug feature, "headers", which allows the headers for a > request to always be logged to the error log (instead of only logging > them when an error has occurred). > > * Updated pkg.depotd man page. > > * Re-worked client intent logic to accommodate subtle changes in the API > so that it works correctly again. > > * Added "target" field to intent information header, which provides the > FMRI of the package related to the manifest being retrieved if different > from initial_target. If initial_target is the same, target is omitted > (since we're downloading the manifest because the user is installing the > same fmri). > > * Fixed the sending of prior_version intent information. > > * Added a test suite for verifying that client intent information is > sent to the depot server correctly. > > * Added ability to specify which debug features to enable to depot test > suite classes. > > Cheers, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
