Shawn,

LGTM.  That's really some awesome automated testing.
Tom


Shawn Walker wrote:
> Shawn Walker wrote:
>   
>> Greetings,
>>
>> The following webrev contains fixes or changes for the following issues:
>>
>>    6245 intent information is not properly sent
>>    6273 ability to always log request headers desired
>>
>> webrev:
>> http://cr.opensolaris.org/~swalker/pkg-6245-6273/
>>
>> Change Summary:
>> * Added --debug command-line option to pkg.depotd
>>
>> * Added pkg/debug SMF property
>>
>> * Added --debug feature, "headers", which allows the headers for a 
>> request to always be logged to the error log (instead of only logging 
>> them when an error has occurred).
>>
>> * Updated pkg.depotd man page.
>>
>> * Re-worked client intent logic to accommodate subtle changes in the API 
>> so that it works correctly again.
>>
>> * Added "target" field to intent information header, which provides the 
>> FMRI of the package related to the manifest being retrieved if different 
>> from initial_target.  If initial_target is the same, target is omitted 
>> (since we're downloading the manifest because the user is installing the 
>> same fmri).
>>
>> * Fixed the sending of prior_version intent information.
>>
>> * Added a test suite for verifying that client intent information is 
>> sent to the depot server correctly.
>>
>> * Added ability to specify which debug features to enable to depot test 
>> suite classes.
>>     
>
> Would like at least one more reviewer.
>
> Thanks!
>
>   

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to