Shawn, > * made depot manifest operation streaming
I haven't had a chance to finish this review, but I had a question about this point. It looks like file/0 and manifest/0 have response.stream set to True. The CherryPY documentation seems to indicate that we shouldn't really use the streaming features unless it's absolutely necessary. At least on the client side, we don't need streaming for files or manifests. Why is this enabled serverside? Does the depot still print correct content-length headers for the manifest? We need that functionality to guard against corruption until we have manifest signing. Does setting streaming to True have any performance impact on pkg client performance? -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
