[email protected] wrote: > Shawn, > >> * made depot manifest operation streaming > > I haven't had a chance to finish this review, but I had a question about > this point. It looks like file/0 and manifest/0 have response.stream > set to True. The CherryPY documentation seems to indicate that we > shouldn't really use the streaming features unless it's absolutely > necessary.
I don't interpret their text as "absolutely necessary"; but rather, whenever beneficial enough that the benefits outweigh the risks. > At least on the client side, we don't need streaming for files or > manifests. Why is this enabled serverside? Does the depot still print I'm not sure what you mean about the "why". > correct content-length headers for the manifest? We need that Yes; content-length still gets sent. > functionality to guard against corruption until we have manifest > signing. Does setting streaming to True have any performance impact on > pkg client performance? In theory, it should be better. We may not be able to tell a difference with an Apache proxy in front. In retrospect, manifest probably isn't is a prime candidate for streaming, but I believe file is given the cherrypy admonition about "pages which take many minutes to produce." Also, I would think it would make sense to stream files, since we wouldn't want the server to buffer an entire 1GB file before sending it out; it should just send the file as it reads it (streaming). Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
