On Tue, Feb 10, 2009 at 01:03:43AM -0600, Shawn Walker wrote:
> Danek Duvall wrote:
>> On Mon, Feb 09, 2009 at 03:33:29AM -0600, Shawn Walker wrote:
>>
>>> http://cr.opensolaris.org/~swalker/pkg-2691/
>>
>> Any chance you can cook up an auxiliary webrev that does diffs between the
>> old repository.py and the new depot.py? It's pretty hard to review these
>> changes as-is. I haven't reviewed it yet; if you can't or don't want to
>> do
>> this, say so, and I'll figure it out myself.
>
> Sorry about that:
> http://cr.opensolaris.org/~swalker/pkg-2691/repo-depot-diff.txt
- line 248: re-wrap
I also forgot about these yesterday:
build_entire_incorporation:
- line 50: "print" instead of "ls"
solaris.py:
- line 29: why?
- line 1200: Ditch the comma after RuntimeError
- line 1303: spaces around operators. If you used "100.0", could you
skip making total a float? Perhaps if you multiplied first? Indeed,
then you probably wouldn't need floating point at all.
- line 1305: I'm confused by refresh_publish. I would expect it to mean
that we need to refresh, but you refresh only when refresh_publish is
False?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
