Danek Duvall wrote:
On Tue, Feb 10, 2009 at 01:03:43AM -0600, Shawn Walker wrote:
Danek Duvall wrote:
On Mon, Feb 09, 2009 at 03:33:29AM -0600, Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-2691/
Any chance you can cook up an auxiliary webrev that does diffs between the
old repository.py and the new depot.py? It's pretty hard to review these
changes as-is. I haven't reviewed it yet; if you can't or don't want to
do
this, say so, and I'll figure it out myself.
Sorry about that:
http://cr.opensolaris.org/~swalker/pkg-2691/repo-depot-diff.txt
...
I also forgot about these yesterday:
...
build_entire_incorporation:
- line 50: "print" instead of "ls"
Really? That doesn't seem to work: "command not found".
solaris.py:
- line 29: why?
Because many of our exceptions use _() now and fail if gettext isn't
installed.
- line 1305: I'm confused by refresh_publish. I would expect it to mean
that we need to refresh, but you refresh only when refresh_publish is
False?
Perhaps the variable name is not helpful enough. In short, if
refresh_publish is true, that means to refresh *when* publishing the
package. So, if that isn't true, it needs to be done at the end instead.
I've renamed this to 'defer_refresh' and added a comment.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
