Packagemanager.py:
1374: please try to be more exact than catching all exceptions here. except: or except Exception: can be problematic from a maintenance standpoint. Also, I suspect there are exceptions that you probably don't want to actually catch at that point.

I'm not seeing a cache.py file, shouldn't there be one in the webrev?

Thanks,
Brock

Michal Pryc wrote:
Hi,
The webrev is available at:
http://cr.opensolaris.org/~migi/6725_v1/

This change will allow to dump the gtk.ListStore to the cpickle files which 
will allow loading gui and switching between categories much faster:

Startup for the http://pkg.opensolaris.org/dev (1653 single packages)
 - startup without cache: 30.323s
 - startup with cache: 5.356s

Startup for the http://pkg.opensolaris.org/pending (11326 single packages)
 - startup without cache: 49.122s
 - startup with cache: 20.254s


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to