Brock, Thanks for review. Indeed I forgot to run hg add before generating webrev from the clean gate. http://cr.opensolaris.org/~migi/6725_v2/
> Packagemanager.py: > 1374: please try to be more exact than catching all exceptions here. > except: or except Exception: can be problematic from a maintenance > standpoint. Also, I suspect there are exceptions that you probably > don't want to actually catch at that point. I am not sure what would be the best solution at this point. We are caching Exception if reading of the cache fails, so we can proceed with silent fallback to non-cache call. I was trying to break the cache files, remove permissions etc. and it was working fine. The problem with the GUI is that if we will not catch some certain exception which will occur then the UI will be frozen and the only possibility to debug it is to go to the terminal and re-run it again. For the cache I believe it should all happens behind the scenes and do not interrupt user even if the cache is broken for some reason - we will recreate it automatically then. best Michal > I'm not seeing a cache.py file, shouldn't there be one in the webrev? > > Thanks, > Brock > > Michal Pryc wrote: > >Hi, > >The webrev is available at: > >http://cr.opensolaris.org/~migi/6725_v1/ > > > >This change will allow to dump the gtk.ListStore to the cpickle files > which will allow loading gui and switching between categories much faster: > > > >Startup for the http://pkg.opensolaris.org/dev (1653 single packages) > > - startup without cache: 30.323s > > - startup with cache: 5.356s > > > >Startup for the http://pkg.opensolaris.org/pending (11326 single packages) > > - startup without cache: 49.122s > > - startup with cache: 20.254s > > > > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
