On Thu, Feb 19, 2009 at 07:04:15PM -0800, johan...@sun.com wrote: > >> indexer.py: > >> > >> - line 396: Is this redundant? Or is fmri_list not a list? If not, > >> should we name it something less confusing? > >> > > What ends up reaching there is a generator of fmris. I'm fine with changing > > it. Would 'fmris' work? > > Ah, I somehow missed that. How about fmri_gen, or something that > indicates it's a generator function?
Please don't. If you treat it as an iterable, you should be able to pass in a list, a set, a tuple, a generator, whatever, and giving it a name based on what its type is is silly. We've done this way too much already. If it's not clear what it is, beef up the docstring. Danek _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
