Dan Price wrote:
On Fri 27 Feb 2009 at 06:10PM, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-6905-v1/
Bug:
6905: pkg.depotd --refresh-index can't fork
http://defect.opensolaris.org/bz/show_bug.cgi?id=6905
Small change which fixes the logic used to decide when the server should
try to reindex and whether it forks if it decides to or not.
This looks Ok to me -- are there any test cases which should
go with any of this?
-dp
Yes, but I don't know how to make them given our current testsuite. We
need a better depot testing infrastructure, but I don't know how to
build that right now. I'll suggest that I file a test suite bug pointing
out a need for a test case for this fix. It's also not an easy condition
to detect externally, I only noticed it in the first place because,
thanks to the timing being right, instead of simply forking once and
that being the end of things as happens when I test on my desktop, on
ipkg, the timing was right such that a stream of forks happened. If I'm
missing a way to test this, please let me know, otherwise I'm going to
defer the test case for now.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
