Greetings,

The following webrev contains fixes for the following issues:

  3739 pkg.depotd traceback on malformed requests

webrev:
http://cr.opensolaris.org/~swalker/pkg-3739/

Change Summary:
* Added VersionError base exception class to pkg.version; changed existing exceptions to inherit from it.

* Added UnsupportedOperation exception to pkg.fmri

* Changed pkg.fmri to raise UnsupportedOperation instead of assertion failure whenever version is missing for get_dir_path, get_link_path, and get_url_path methods.

* Fixed pkg.server.depot to properly return httplib.BAD_REQUEST errors whenever an FmriError is encountered.

* Changed pkg.server.repository to only expect FmriError for InvalidFMRI exception case

* Changed pkg.server.transaction to only expect FmriError for InvalidFMRI exception case

* Added tests to tests/api/t_fmri to verify that UnsupportedOperation exceptions are raised as appropriate.

* Added tests to tests/api/t_fmri to verify that IllegalFmri exceptions are raised when an attempt to construct an FMRI with bad version information is made.

* Added tests to tests/cli/t_pkg_depotd to verify that a depot will return a 400 error whenever a bad FMRI request is made for info and manifest operations.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to