Danek Duvall wrote:
On Fri, Mar 06, 2009 at 01:11:23AM -0600, Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-3739/
Should the subclasses of FmriError and VersionError call the __init__()
methods of FmriError and VersionError, respectively, rather than of
Exception directly?
Yes.
Do you have ideas for other unsupported operations? It seems to me that
having a MissingVersionError would be more useful right now (as well as
more compact when raising it), and it could always be converted to a
subclass of something later on, if actually necessary.
Agreed.
Updated webrev:
http://cr.opensolaris.org/~swalker/pkg-3739-2/
diff from last webrev:
http://cr.opensolaris.org/~swalker/pkg-3739-2/v1-v2.patch
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
