On Mon 09 Mar 2009 at 11:57PM, jmr wrote:
> Hi,
>
> Here is the final webrev for Webinstall. Its been reviewed and tested
> against the current gate that contains Shawn's Publisher API.
>
> http://cr.opensolaris.org/~jmr/pm_webinstall_merge_with_gate_mar09_11pm/
> #6352: Add MimeType support for adding Authorities and Packages via PM
src/gui/Makefile:
I carefully alphabetized everything in this makefile so that
it would be easy to maintain. You've broken that all over.
Please fix; I want to re-review this before it goes in.
Have you tested your makefiles for compliance with the gate
makefile policy?
packagemanger-info.xml -- needs sun copyright, license?
gui_pylintrc -- it sort-of seems to be self defeating if
you relax the rules more and more. Is it really sensible
to have a function which takes 20 args?
This is what I had time to review.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
