John,
Could you please change the copyright date in the gui_pylintrc?
The rest looks fine.
best
Michal
jmr wrote:
Dan - followup webrev posted at:
http://cr.opensolaris.org/~jmr/pm_webinstall_merge_with_gate_followon_mar09_12pm/
Makefile updated to be as alphabetical as possible.
Makefile policy has been checked and this is fine as far as I can tell.
Running make twice and make install twice we see the same directory
traversal only.
Copyright included in packagemanger-info.xml.in
Reduced num args limit in pylint to 15. InstallUpdate's constructor is
using 13 which could be reduced a little.
JR
jmr wrote:
Thanks Dan for taking a look. Michal has been reviewing this over the
past 2 days and Padraig also, so we have already incorporated a lot of
feedback.
We'll send a follow up webrev shortly for you to review, before we
head to bed.
JR
src/gui/Makefile:
I carefully alphabetized everything in this makefile so that
it would be easy to maintain. You've broken that all over.
Please fix; I want to re-review this before it goes in.
Happy to submit a follow on to reorganize the entries alphabetically,
we are maintaining it and were not aware that you wanted kept in
alphabetical order.
Have you tested your makefiles for compliance with the gate
makefile policy?
packagemanger-info.xml -- needs sun copyright, license?
No problems will add as that in src/brand/config.xml, we have tested
that adding copyright info to the mime type /usr/share/mime/packages/
file is not a problem. None of the other files delivered into this dir
have copyright info.
gui_pylintrc -- it sort-of seems to be self defeating if
you relax the rules more and more. Is it really sensible
to have a function which takes 20 args?
I'll take a look.
This is what I had time to review.
-dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
